Skip to content

Skip the unstable SYNCHRONOUS_DNS_CACHE testcase #8171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 20, 2018
Merged

Skip the unstable SYNCHRONOUS_DNS_CACHE testcase #8171

merged 1 commit into from
Sep 20, 2018

Conversation

SeppoTakalo
Copy link
Contributor

Description

Skip the unstable SYNCHRONOUS_DNS_CACHE testcase

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@SeppoTakalo
Copy link
Contributor Author

@KariHaapalehto or @VeijoPesonen please review.

cmonr
cmonr reviewed Sep 19, 2018
View reviewed changes
TESTS/netsocket/dns/main.cpp Outdated
@@ -178,7 +178,8 @@ Case cases[] = {
#endif
Case("SYNCHRONOUS_DNS", SYNCHRONOUS_DNS),
Case("SYNCHRONOUS_DNS_MULTIPLE", SYNCHRONOUS_DNS_MULTIPLE),
#ifdef MBED_EXTENDED_TESTS
#if 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not completely remove it? If we need to refer to it later, it's in the git history.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 19, 2018

As noted above, it would be better to have unstable test completely removed but with tracking issue to fix it. Rather than #if 0 (that should not be left in the code).

@SeppoTakalo
Copy link
Contributor Author

Please don't delay this.

It is not very helpful to scan our CI jobs for real failures, when it all looks like this:
image
image

test case will be fixed or removed, when we have enough resources to do so.

@SeppoTakalo SeppoTakalo mentioned this pull request Sep 20, 2018
Closed
@0xc0170
Remove the unstable SYNCHRONOUS_DNS_CACHE testcase
558b579 
Will be reverted once the test case is fixed
@0xc0170
Copy link
Contributor

0xc0170 commented Sep 20, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Sep 20, 2018

Build : SUCCESS

Build number : 3114
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8171/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Sep 20, 2018

Exporter Build : SUCCESS

Build number : 2721
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8171/

@mbed-ci
Copy link

mbed-ci commented Sep 20, 2018

Test : SUCCESS

Build number : 2907
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/8171/2907

@cmonr cmonr merged commit c005ba2 into ARMmbed:master Sep 20, 2018
@cmonr cmonr removed the needs: CI label Sep 20, 2018
@SeppoTakalo SeppoTakalo deleted the skip-dns-test branch November 7, 2018 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr left review comments

@0xc0170 0xc0170 0xc0170 approved these changes

@VeijoPesonen VeijoPesonen VeijoPesonen approved these changes

@KariHaapalehto KariHaapalehto Awaiting requested review from KariHaapalehto

Assignees
No one assigned
Labels
release-version: 5.10.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SeppoTakalo @0xc0170 @mbed-ci @cmonr @VeijoPesonen